Web Hosting Talk : Web Hosting Main Forums : Programming Discussion : Basic ASP problem

[AstarothT]

First of all I feel I must apologise for asking such a basic question.....

I am not the best person at asp in the world but even I could normally workout this sort of issue but I cant see the wood for the trees on this problem


Error message:
Microsoft VBScript compilation error '800a03ea'
Syntax error
/insurance/content_20.asp, line 29
elseif ave_score > 4.25 then rating_image = "rating-4+.gif"
^


Code:
<% ave_score = (company_details.Fields.Item("ave_score").Value)
If ave_score >= 4.75 then rating_image = "rating-5.gif"
elseif ave_score > 4.25 then rating_image = "rating-4+.gif"
elseif ave_score > 3.75 then rating_image = "rating-4.gif"
elseif ave_score > 3.25 then rating_image = "rating-3+.gif"
elseif ave_score > 2.75 then rating_image = "rating-3.gif"
elseif ave_score > 2.25 then rating_image = "rating-2+.gif"
elseif ave_score > 1.75 then rating_image = "rating-2.gif"
elseif ave_score > 1.25 then rating_image = "rating-1+.gif"
elseif ave_score > 0 then rating_image = "rating-1.gif"
else rating_image = "rating-0.gif"
End if
%>


As far as i am aware I can just define it as a series of > queries but incase I couldnt I have also tried defining each like as being between 2 scores and I get the identical error

Many thanks

[DatabaseMart]

AstarothT,

You missed "Then" keyword.

If ave_score >= 4.75 then rating_image = "rating-5.gif" Then
elseif ave_score > 4.25 then rating_image = "rating-4+.gif" Then
.......

[DatabaseMart]

Actually it's better to use "Select Case" statement.

Select Case ave_score
Case >= 4.75 rating_image = "rating-5.gif"
Case >= 4.25 ......
Case Else ....
End Select

[AstarothT]

Many thanks both - knew it would be something simple that I missed.

[AstarothT]

Ok, corrected my code to what you suggested DatabaseMart:

<% ave_scores = (company_details.Fields.Item("ave_score").Value)
Select Case ave_scores
case >= 4.75 rating_image = "rating-5.gif"
case > 4.25 rating_image = "rating-4+.gif"
case > 3.75 rating_image = "rating-4.gif"
case > 3.25 rating_image = "rating-3+.gif"
case > 2.75 rating_image = "rating-3.gif"
case > 2.25 rating_image = "rating-2+.gif"
case > 1.75 rating_image = "rating-2.gif"
case > 1.25 rating_image = "rating-1+.gif"
case > 0 rating_image = "rating-1.gif"
case else rating_image = "rating-0.gif"
End Select
%>

Error message is basically the same (though the arrow is in a different place..... not sure whats going

Microsoft VBScript compilation error '800a03ea'
Syntax error
/insurance/content_20.asp, line 30
case >= 4.75 rating_image = "rating-5.gif"
-----^

Cheers

[DatabaseMart]

AstarothT,

Sorry. It cannot work like that way. Please try this. It doesn't have any performance advantages comparing with "If ElseIf End If" statement.

	Select Case True
		Case ave_scores > 4.75 rating_image = "rating-5.gif"
		case ave_scores > 4.25 rating_image = "rating-4+.gif" 
		case ave_scores > 3.75 rating_image = "rating-4.gif" 
		case ave_scores > 3.25 rating_image = "rating-3+.gif"
		case ave_scores > 2.75 rating_image = "rating-3.gif" 
		case ave_scores > 2.25 rating_image = "rating-2+.gif"
		case ave_scores > 1.75 rating_image = "rating-2.gif" 
		case ave_scores > 1.25 rating_image = "rating-1+.gif"
		case ave_scores > 0 rating_image = "rating-1.gif"
		case else rating_image = "rating-0.gif"
	End Select