Web Hosting Talk : Web Hosting Main Forums : Programming Discussion : Feedback on PHP image script?

[GeorgeC]

Hi:
I'm looking for some feedback on this PHP image optimizing script I just completed: http://webmasterpick.com/gifoptimize/ Please let me know if you find any bugs or other more serious issues (pm please when more appropriate). What about a certain features that you think are missing or would be useful?

Thanks,

[funkytaco]

Awesome script.

[GeorgeC]

Thanks. If anyone has feedback on bugs or potential security issues, please let me know as well.

[stormraven]

Sweet script!

[bentruyman]

Nice.

Why not make another one in which you can resize it by percentage, number, best fit ratio, and resample it to a set quality? :-)

It's actually really. I just did one in fact for a client.

-Ben

[bentruyman]

This is my script. I had a little help from someone here on WHT. But all the calculations are mine.

PHP Code:

<?
/*==Image Resizer=====================================*/
/*This script currently does NOT support other formats*/
/*other than JPG or JPEG.  Though, I made it for      */
/*photos which should be in JPG format anyways.       */
/*Basically, it will take the file uploaded, determine*/
/*which proportion is greater (width or height) and   */
/*resize it to fit within the constraints given.      */
/*====================================================*/
/*Notice the calculations.*/
function resizeToFile ($sourcefile, $max_x, $max_y, $targetfile, $jpegqual) {
/* Get the dimensions of the source picture */
$picsize=getimagesize("$sourcefile");
$source_x = $picsize[0];
$source_y  = $picsize[1];
$source_id = imageCreateFromJPEG("$sourcefile");
/* Best fit image */
/*This is where the script checks for the greater ratio.*/
/*If you have an image resize script, this would be the */
/*section that determines the 'best fit' for a pair of  */
/*constraints given.                                    */
if(($source_x/$max_x) > ($source_y/$max_y))
{
    $ratio = $source_x/$max_x;
    $max_y=$source_y/$ratio;
}
else
{
    $ratio = $source_y/$max_y;
    $max_x=$source_x/$ratio;
}
/* Create image object */
$target_id=imagecreatetruecolor($max_x, $max_y);
/* Resize JPG */
$target_pic=imagecopyresampled($target_id,$source_id,0,0,0,0,$max_x,$max_y,$source_x,$source_y);
/* Create JPG */
imagejpeg ($target_id,"$targetfile",$jpegqual);
return true;
}
?>

[mfonda]

easybyte: hard to give feedback, especially on "bugs or potential security issues" as you request, if you do not post the PHP code to it.

nonetheless, looks cool, a nice idea, and useful

[Bakie]

Looks good but I havent tried it out yet but I will probably need it soon so I bookmarked it.

[pergesu]

When I tried it, it said the pic was too big.

http://www.photofile.com/Photos/Albu...rmeloASG01.jpg

Not that big of an image, really.

[GeorgeC]

Originally posted by pergesu
When I tried it, it said the pic was too big.

http://www.photofile.com/Photos/Albu...rmeloASG01.jpg

Not that big of an image, really.

Currently I'm limiting image size to 100k, so you're getting that error (image is 140k). I'll probably double that limit depending on how it affects my server resources.