Web Hosting Talk : Web Hosting Main Forums : Programming Discussion : Need MySQL help

[Tatha]

Hi everyone,

I need some help with a MySQL/php form, it's complaining about something I've just added and I can't work out what's wrong. Here's the error I got:

You have an error in your SQL syntax near 'bureauinf='0', churchinf='0', financeinf='0', healthinf='0', highinf='0', indust' at line 1** 1064

And here's the code for what I added:

$bureauinf=$data['bureauinf'];$churchinf=$data['churchinf'];
$financeinf=$data['financeinf'];$healthinf=$data['healthinf'];
$highinf=$data['highinf'];$industryinf=$data['industryinf'];
$legalinf=$data['legalinf'];$mediainf=$data['mediainf'];
$occultinf=$data['occultinf'];$policeinf=$data['policeinf'];
$politicsinf=$data['politicsinf'];$streetinf=$data['streetinf'];
$transportinf=$data['transportinf'];$underworldinf=$data['underworldinf'];
$universityinf=$data['universityinf'];
$sql=$sql."bureauinf='$bureauinf', churchinf='$churchinf', financeinf='$financeinf', healthinf='$healthinf', ";
$sql=$sql."highinf='$highinf', industryinf='$industryinf', legalinf='$legalinf', mediainf='$mediainf', ";
$sql=$sql."occultinf='$occultinf', policeinf='$policeinf', politicsinf='$politicsinf', streetinf='$streetinf', ";
$sql=$sql."transportinf='$transportinf', underworldinf='$underworldinf', universityinf='$unversityinf', ";
$result=mysql_query($sql);

Can anyone see what I did wrong?

Tatha

[Kattilyn]

You're ending the SQL query with a comma AND not terminating it with a semicolon, for starters..?

[Tatha]

I saw that and fixed it, but it's still giving me grief

[Kattilyn]

What is $sql set to before these lines?

[null]

PHP Code:

$sql = "SELECT * FROM table WHERE ";

$bureauinf=$data['bureauinf'];
$churchinf=$data['churchinf'];
$financeinf=$data['financeinf'];
$healthinf=$data['healthinf'];
$highinf=$data['highinf'];
$industryinf=$data['industryinf'];
$legalinf=$data['legalinf'];
$mediainf=$data['mediainf'];
$occultinf=$data['occultinf'];
$policeinf=$data['policeinf'];
$politicsinf=$data['politicsinf'];
$streetinf=$data['streetinf'];
$transportinf=$data['transportinf'];
$underworldinf=$data['underworldinf'];
$universityinf=$data['universityinf'];

$sql .= "bureauinf = '\$bureauinf', churchinf = '\$churchinf', financeinf = '\$financeinf', healthinf = '\$healthinf', ";
$sql .= "highinf = '\$highinf', industryinf = '\$industryinf', legalinf ='\$legalinf', mediainf = '\$mediainf', ";
$sql .= "occultinf = '\$occultinf', policeinf = '\$policeinf', politicsinf = '\$politicsinf', streetinf = '\$streetinf', ";
$sql .= "transportinf = '\$transportinf', underworldinf = '\$underworldinf', universityinf = '\$unversityinf'";

$result=mysql_query($sql); 


[Tatha]

$sql="Select * from charsheets where name='$charname'";

[Kattilyn]

First, scratch those slashes you've added in there before each $.

Second, there is no space between

$sql = "Select * from charsheets WHERE name='$charname'";

And the next

$sql .= "bureainf blah blah";

There needs to be a space.. but more important, there needs to be an AND or an OR, not a comma..

Example:

$sql = "SELECT * FROM charsheets WHERE name='$charname'";
$sql .= " AND bureauinf='$bureauinf' AND churchinf='$churchinf' AND financeinf='$financeinf'";

Can substitute OR for AND. See http://www.mysql.com/doc/en/Selecting_rows.html for more information.

[Burhan]

You don't need a semicolon at the end of your query, iirc, it will not execute with a semicolon at the end. You however do need a semicolon to terminate the statement.

PHP Code:

// Not this
$query = "SELECT * FROM table WHERE field = 'value';";

//But this
$query = "SELECT * FROM table WHERE field = 'value'";