Results 1 to 13 of 13
  1. #1
    Join Date
    Jul 2001
    Location
    London, UK
    Posts
    44

    What do you think?

    Since I last posted in this forum (which was an age ago), I have done some tweaking to the site, mainly cosmetic but I've now dumped in includes.etc for easier editing and so on...

    http://agccworld.co.uk - what do you think?

    Both positive and negative constructive feedback is appreciated
    Andrew Gearing
    AGCC Limited
    AGCC.net
    AGCCWorld.com

  2. #2
    Join Date
    Jan 2003
    Location
    Houston, TX - Originally from UK
    Posts
    707
    After a quick look, a few things worth mentioning:

    1. Good to see use of CSS, but shy away from sizing fonts in "pt"s. Points are a means of sizing for print, not screen, and don't adapt very well. You've got the choice of pixels (px) if you want to keep absolute sizing, or ems and percentages if you want relative sizing.

    2. Add a doctype. Validate.

    3. Remove your <font> tags. Add a couple of classes for your horizontal and vertical navigation and place the formatting in those.

    4. Use an external stylesheet and call it via a <link rel...> in your <head>. Means every page can use the same stylesheet and cuts down on end-users download times.

    Otherwise, good looking site. The visuals I'll leave to others to comment on!

    Regards,
    Zopester
    Last edited by Zopester; 01-14-2003 at 06:25 AM.
    Kinkamono Internet Services - The Internet. Done Right.
    Dive In...

  3. #3
    Join Date
    Jan 2003
    Location
    Houston, TX - Originally from UK
    Posts
    707
    ok...after a closer look, I've spotted something. You've got nested html documents in one page. This is "A Bad Thing". Standards-compliant browsers may make a complete mess of rendering the page, and even non-standards-compliant ones won't like it too much!

    I see no real reason for the nesting. Take out the unnecessary <html> tags etc, and create one coherent page.

    Zopester
    Kinkamono Internet Services - The Internet. Done Right.
    Dive In...

  4. #4
    Join Date
    Jul 2001
    Location
    London, UK
    Posts
    44
    Hi there - thanks for the comments

    When you say nesting do you mean an include? as there are php includes in the documents to make it easier to add links to the navigation.etc
    Andrew Gearing
    AGCC Limited
    AGCC.net
    AGCCWorld.com

  5. #5
    Looks like your includes are in their own <html> tags. You don't need them there and, as Zopester said, they'll send some browsers screwy.

  6. #6
    Join Date
    Jul 2001
    Location
    London, UK
    Posts
    44
    OK ill have a look in a mo
    Andrew Gearing
    AGCC Limited
    AGCC.net
    AGCCWorld.com

  7. #7
    Join Date
    Jan 2003
    Location
    Houston, TX - Originally from UK
    Posts
    707
    Yes, as Victor says, just strip the <html> tags etc from the php includes, save, hit refresh on your browser and you should be good to go.
    Kinkamono Internet Services - The Internet. Done Right.
    Dive In...

  8. #8
    Some padding to the left of your menu and pro package columns would help. Remember to set a BG color for your pages - they are mostly lavender on my screen. Hard to get an idea the look you intended until you change the BG color. Since I have flash disabled, there are a lot of blank spaces on your page. Logo is a bit small, thumbs up lady doesn't add a thing IMO and scrollbar looks kinda' clunky.
    "Genetically engineered food
    is corporate bioterrorism"

    --- musings of a human guinea pig

  9. #9
    Join Date
    Jan 2003
    Posts
    169
    its ok
    Dustin

  10. #10
    Join Date
    Jul 2001
    Location
    London, UK
    Posts
    44
    Hi just an update - all the <html> tags from the includes have been removed to make it more browser complaint, going to work on the "main body" later today.
    Andrew Gearing
    AGCC Limited
    AGCC.net
    AGCCWorld.com

  11. #11
    Join Date
    Jan 2003
    Location
    Houston, TX - Originally from UK
    Posts
    707
    Yes, that's better! Visuals can always be tweaked, but if it ain't a proper html document to begin with, yer stuffed!

    Good work...looking forward to seeing the results of your labours.
    Kinkamono Internet Services - The Internet. Done Right.
    Dive In...

  12. #12
    You can have perfect code but it still won't render correctly unless you set a BG color. Here's what I'm seeing!
    Attached Thumbnails Attached Thumbnails no bg.jpg  

  13. #13
    Join Date
    Jan 2003
    Location
    Houston, TX - Originally from UK
    Posts
    707
    Ya know sisterscape, I always say I'll mention that, but always forget!
    Kinkamono Internet Services - The Internet. Done Right.
    Dive In...

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •