berlin
12-08-2007, 06:29 AM
not sure if i'm using the right term... i'm having a prototype built and i found that the programmer I hired isn't using php to show form errors. he's using javascript. there are 20 different forms in this app, from user profiles to submitting photos and videos. should i get him to use php?
also he didn't use a separate language file and I suspect that the script isn't template based either. it will be so difficult to separate after everything is finished. and he's still using tables and not pure css. is this ok?
mitchlrm
12-08-2007, 06:54 AM
Using javascript is reasonable for some form errors but not errors related to stored data (like checking a password). I prefer php but javascript is quite reasonable for many types of error checking.
Yea, separating Javascript into a separate file is a good thing, particularly for common functions. Scripts aren't really template based, I'm not sure what you're asking here. Scripts can be attached to templates but scripts need to match your requirements.
Tables vs. css: There are still legitimate uses for tables, even for the css fanatics. The purists would argue for not using tables for common formatting of web pages but it really depends on what your requirements are.
Steve_Arm
12-08-2007, 07:25 AM
If he doesn't use any PHP for server side data validation... hmm... find another coder. Common sense.
Codebird
12-08-2007, 04:38 PM
you should get him to use some php for things that may cause harmful things to your server cause javascript can be easily disable in the browser
berlin
12-09-2007, 04:39 PM
Thanks for all the replies. I don't know what to do now. They've been avoiding my suggestions and I'm already $1k deep with these guys.
BlueHayes
12-09-2007, 04:45 PM
Just because there is Javascript validation being made first, it doesn't mean this isn't being backed by PHP (as it should be). Not sure if you've checked or asked, but just make sure there is PHP validation in addition to javascript where required. Being client side, the javascript obviously doesn't provide sufficient error checking and handling in most cases :) Good luck with the project! I would really try and get it full contact with whoever is programming it and make sure you're on equal terms and understanding before any more work is done... just tell the person that if they're not willing to stop and talk to you for a breather - you're out!
mitchlrm
12-09-2007, 05:39 PM
berlin,
You're obviously concerned about the project. I would suggest laying down your concerns to these folks and also paying for an outside code review. The code review should be pretty high level, just to confirm or deny any major problems, not debug all the code. While an outside code review will cost you some money, it will either confirm or deny your concerns. If you're concerns are justified, find someone else to do the work. While $1k is a lot of money, no use spending more with the wrong people.
I'm in your general area, contact me if I can be of help...but there are lots of people in the Bay Area with the appropriate skills.
Codebird
12-09-2007, 05:44 PM
I can put myself in your place, and I see it's bad, I would help u as much as I can for free.
Xeentech
12-10-2007, 10:06 AM
... the programmer I hired isn't using php to show form errors. he's using javascript.
IMO using JavaScript like this is very good for the user experience, ie highlighting errors with red CSS 1px borders etc. It falls apart when either the user has disabled script, your script some how fails, or the user isn't even in the browser and is submitting bogus data with a tool like cURL. Server side validation is a must.
also he didn't use a separate language file and I suspect that the script isn't template based either. it will be so difficult to separate after everything is finished.
You're right here. If it's all in one long sparling .php file it will be a pain to maintain and build upon in the future, and likely a nightmare to debug. If the developer is already trying to ignore your suggestions I don't really know what to suggest. Perhaps at this stage it would be possible to rip content, logic and layout apart and start on a template based architecture. I don't know how close to completion you are though.
and he's still using tables and not pure css. is this ok?
Do you mean he's using tables for tabular data? I do hope that's what you mean here.. I had a client that expected all the site to be CSS/xHTML once, even this mock-spreadshteet of invoices / orders. I had to explain to them that it is ok to use tables for things like this, and that is not what is meant by "table-less" design.
On the other hand, if the dev is using tables for layout.. I fear the situation may be hopeless. Techniques used to build your site will be years out of date on launch, and god only know what other arcane methods he's using to build the thing.
Good luck with this whole thing Berlin.